-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine exporter and cacher phases #205
Combine exporter and cacher phases #205
Conversation
This will mean a breaking change for
I think we're probably still at an ok place to make breaking changes, but if this were to be the only breaking in change in a release I would want us to consider ^ |
e44a502
to
21c50a4
Compare
Combines the exporter and cacher phases to reuse layer tarballs. * Move logic from cacher.go to exporter.go. * Move tests from cacher_test.go to exporter_test.go. * Rename cache image flag from '-image' to '-cache-image'. * Rename cache directory flag from '-path' to '-cache-dir'. * Remove unused 'In' field of the Exporter struct. * Remove cacher implementation, tests, and command. Signed-off-by: Lukas Berger <[email protected]>
Signed-off-by: Lukas Berger <[email protected]>
Signed-off-by: Lukas Berger <[email protected]>
21c50a4
to
7071c70
Compare
Signed-off-by: Lukas Berger <[email protected]>
@lukasberger I approved this and #207. This one could use a tiny bit of cleanup once it can be rebased on #207 (see comments). I think we need |
@ekcasey The pack changes were merged in buildpacks/pack#384. Depending on how everyone else feels about the flag name cleanup that @jromero proposed being part of this PR, I can make the changes in pack as well. Regarding the cleanup, did you mean after #207 is merged, or do you want me to rebase this PR on top of the other branch? |
@lukasberger Now that I realize the changes are already merge in After they are merged you (or another contributor) can open a PR refactoring |
Combines the exporter and cacher phases to reuse layer tarballs.
Part of the implementation of buildpacks/rfcs#21.
Signed-off-by: Lukas Berger [email protected]