builds have reproducible results (with caveats) #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* caveat 1: CNB lifecycle cannot fix nonreproducbile buildpack layer file contents
* caveat 2: a local and remote build will not produce the same image digest because:
-- the remote image will have an image digest in the runImage.reference field in the io.buildpacks.lifecycle.metadata label
-- the local image will have an image ID in the runImage.reference field in the io.buildpacks.lifecycle.metadata label
Signed-off-by: Emily Casey <[email protected]>
ekcasey
force-pushed
the
reproducibility
branch
from
cf88297 to
384a98e
Compare
sclevine
approved these changes
Jan 16, 2020
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- the remote image will have an image digest reference in the
runImage.referencefield in theio.buildpacks.lifecycle.metadatalabel-- the local image will have an image ID in the
runImage.referencefield in theio.buildpacks.lifecycle.metadatalabelSigned-off-by: Emily Casey [email protected]
Caveat 2: listed above exists because, in the daemon case, the
run-imagemay not have a repository digest reference (if it was created locally). However, if we used the imageRepoDigestin the label in the case where exactly 1 did exist, we could have identical local/remote results in the majority of cases.