Handle 404s from harbor #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harbor doesn't seem to return the error code specified in the registry api docs when a manifest is not found. This PR bumps imgutil to a version that gracefully handles all 404s without regarding for the specific error code Signed-off-by: Emily Casey <[email protected]>
matthewmcnew
approved these changes
May 28, 2020
|
❤️ Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harbor doesn't seem to return the error code specified in the registry api docs when a manifest is not found. This PR bumps
imgutilto a version that gracefully handles all 404s without regard for the specific error codeResolves #303