Add support for custom app directory with cmd arg #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Kutner <[email protected]>
sclevine
requested changes
Nov 2, 2018
|
@Zanadar this PR from heroku could make our v3 wrapper easy to implement. For example, we could use |
zmackie
reviewed
Nov 2, 2018
|
This seems like a great idea! |
jkutner
force-pushed
the
jkutner/app-dir2
branch
from
26596f2 to
e0eb22e
Compare
Signed-off-by: Joe Kutner <[email protected]>
jkutner
force-pushed
the
jkutner/app-dir2
branch
from
e0eb22e to
64e383c
Compare
Signed-off-by: Joe Kutner <[email protected]>
|
Feedback addressed |
sclevine
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for a custom named AppDir, or an AppDir that does not reside under the LaunchDir. The default remains
workspace/app, but this also cleans up some hard coded references to"app".I've also introduced a
PACK_APP_DIRenv var to support the launcher, which does not take flags. I'm not sure if this should be a flag. If not, we should maybe add this env var to the spec.The primary use case is backwards compatibility with pre-v3 platforms, and the potential of a compatibility layer with older buildpacks (i.e. a "shim").
Questions