Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove docker compilation for linux binaries #689

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Remove docker compilation for linux binaries #689

merged 1 commit into from
Aug 17, 2021

Conversation

natalieparellano
Copy link
Member

Signed-off-by: Natalie Arellano [email protected]

@natalieparellano natalieparellano requested a review from a team as a code owner August 16, 2021 21:48
@natalieparellano
Copy link
Member Author 

 $  time make clean build
> Cleaning workspace...
rm -rf /Users/pivotal/workspace/lifecycle/out
> Building lifecycle/lifecycle for linux/amd64...
mkdir -p /Users/pivotal/workspace/lifecycle/out/linux-amd64/lifecycle
GOARCH=amd64 CGO_ENABLED=0 go build  -ldflags "-s -w -X 'github.com/buildpacks/lifecycle/cmd.SCMRepository=github.com/buildpacks/lifecycle' -X 'github.com/buildpacks/lifecycle/cmd.SCMCommit=6921d07' -X 'github.com/buildpacks/lifecycle/cmd.Version=0.11.2-176+6921d07'" -o /Users/pivotal/workspace/lifecycle/out/linux-amd64/lifecycle/lifecycle -a ./cmd/lifecycle
> Creating phase symlinks for linux/amd64...
ln -sf lifecycle /Users/pivotal/workspace/lifecycle/out/linux-amd64/lifecycle/detector
ln -sf lifecycle /Users/pivotal/workspace/lifecycle/out/linux-amd64/lifecycle/analyzer
ln -sf lifecycle /Users/pivotal/workspace/lifecycle/out/linux-amd64/lifecycle/restorer
ln -sf lifecycle /Users/pivotal/workspace/lifecycle/out/linux-amd64/lifecycle/builder
ln -sf lifecycle /Users/pivotal/workspace/lifecycle/out/linux-amd64/lifecycle/exporter
ln -sf lifecycle /Users/pivotal/workspace/lifecycle/out/linux-amd64/lifecycle/rebaser
ln -sf lifecycle /Users/pivotal/workspace/lifecycle/out/linux-amd64/lifecycle/creator
> Building lifecycle/launcher for linux/amd64...
...

real    0m55.569s
user    3m47.158s
sys     0m59.914s

 $  docker run --rm -v /Users/pivotal/workspace/lifecycle/out/linux-amd64/lifecycle:/cnb/lifecycle ubuntu:bionic /cnb/lifecycle/lifecycle -version
0.11.2-176+6921d07

@natalieparellano
Copy link
Member Author

Fixes #677

@natalieparellano natalieparellano merged commit 8faa4eb into main Aug 17, 2021
@natalieparellano natalieparellano deleted the remove-docker-compilation branch August 17, 2021 13:49
@natalieparellano natalieparellano mentioned this pull request Aug 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabrown85 jabrown85 jabrown85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natalieparellano @jabrown85