Set Umask as part of archive.Extract #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aemengo, we would love to get your feedback! Thanks! |
yaelharel
commented
Sep 30, 2021
Comment on lines
+19
to
+23
| var ( | ||
| umaskLock sync.Mutex | ||
| extractCounter int | ||
| originalUmask int | ||
| ) |
There was a problem hiding this comment.
We can put these three variables inside a private struct if anyone thinks it'll be clearer.
Or we can even move the variables and the related functions (setUmaskIfNeeded and unsetUmaskIfNeeded) to an internal package.
Personally, I don't think it's necessary but it's an option.
yaelharel
force-pushed
the
umask
branch
3 times, most recently
from
c8e5177 to
6e95ee6
Compare
Signed-off-by: Natalie Arellano <[email protected]>
|
I think this is the best solution. This way we don't force the complexity of setting the umask on the caller. @yaelharel thank you for thinking of it! |
jabrown85
reviewed
Sep 30, 2021
instead at the end of the function in case setUmask will panic. Signed-off-by: Natalie Arellano <[email protected]>
jabrown85
approved these changes
Sep 30, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A different solution for #727.