Add empty layer before saving on remote images #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jjbustamante in the new imgutil |
Interesting, I didn't change anything related to that method. The error came actually after merging this |
|
Ah @jjbustamante that makes sense - we hadn't bumped imgutil in the lifecycle yet. |
# This is the 1st commit message: WIP - Initialized the cache image to add an empty layer in case is needed Signed-off-by: Juan Bustamante <[email protected]> # This is the commit message #2: Fixing compilation error caused by imgutil PR #141 Signed-off-by: Juan Bustamante <[email protected]>
…eded Signed-off-by: Juan Bustamante <[email protected]>
jjbustamante
force-pushed
the
bugfix/add-empty-layer-on-remote-image
branch
from
6387ba3 to
62bcfe6
Compare
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
natalieparellano
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following fix initialized the cached image to add an empty layer in the case is needed
Fixes #830
Signed-off-by: Juan Bustamante [email protected]