Add support for experimental api mode #861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natalieparellano
force-pushed
the
feature/pre-release-api
branch
5 times, most recently
from
764fd44 to
66d188f
Compare
natalieparellano
force-pushed
the
feature/pre-release-api
branch
from
09a21ce to
8166edc
Compare
natalieparellano
commented
Jun 2, 2022
| @@ -0,0 +1,172 @@ | |||
| package cli | |||
There was a problem hiding this comment.
Moved from cmd package
natalieparellano
commented
Jun 2, 2022
| @@ -1,28 +0,0 @@ | |||
| package platform | |||
There was a problem hiding this comment.
Moved to platform/paths.go
natalieparellano
commented
Jun 2, 2022
| @@ -0,0 +1,13 @@ | |||
| package launch | |||
There was a problem hiding this comment.
Avoid having the launcher depend on the platform package, to keep the binary smaller
natalieparellano
force-pushed
the
feature/pre-release-api
branch
from
8166edc to
2591682
Compare
- Refactors cmd package: - Moves platform logic to platform or platform/launch - Moves env and flag parsing to cmd/lifecycle/cli and cmd/launcher/cli - Moves constants for supported & deprecated apis from api package to platform and buildpack packages (this removes all CNB business logic from api) - Creates log package to hold interface, removing duplication Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
force-pushed
the
feature/pre-release-api
branch
from
2591682 to
21f4633
Compare
natalieparellano
force-pushed
the
feature/pre-release-api
branch
from
6399145 to
21f4633
Compare
|
After discussion in 6/9 Working Group, the pre-release api aspect of this PR is not as useful for our current needs (though it may be useful when readying a 1.0 spec). Closing this PR in favor of a smaller PR that just implements experimental features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #459
This (like many PRs of late) ended up being rather huge as I took the opportunity to tackle another long-awaited refactor. The most interesting changes are in the api and platform/guard packages.
Other changes:
platform and buildpack packages (this removes all CNB business logic from api)