Fix: set HOME for provided user after build image extension (#960) #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <[email protected]>
|
cc @BarDweller |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #964 +/- ##
=======================================
Coverage 64.49% 64.49%
=======================================
Files 86 86
Lines 6175 6175
=======================================
Hits 3982 3982
Misses 1809 1809
Partials 384 384
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -71,6 +71,9 @@ func (e *extendCmd) Exec() error { | |||
| if err = priv.RunAs(e.UID, e.GID); err != nil { | |||
| return cmd.FailErr(err, fmt.Sprintf("exec as user %d:%d", e.UID, e.GID)) | |||
| } | |||
| if err = priv.SetEnvironmentForUser(e.UID); err != nil { | |||
There was a problem hiding this comment.
Covered in acceptance
jabrown85
approved these changes
Nov 28, 2022
natalieparellano
added a commit
that referenced
this pull request
Nov 28, 2022
) Signed-off-by: Natalie Arellano <[email protected]> Signed-off-by: Natalie Arellano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Natalie Arellano [email protected]