removes "wall of shas" #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekcasey
force-pushed
the
no-more-wall-of-shas
branch
from
ba52b1c to
b9e1d57
Compare
sclevine
requested changes
Mar 27, 2019
image/remote.go
Outdated
| @@ -258,6 +261,8 @@ func (r *remote) Save() (string, error) { | |||
| return "", err | |||
| } | |||
|
|
|||
| log.SetOutput(ioutil.Discard) | |||
There was a problem hiding this comment.
Mixed feelings about this.
Upside:
- Probably no other way to do this without an upstream PR
log.SetOutputis re-entrant, so a global data race isn't possible
Downside:
- This temporarily disables logging for any functions running in parallel that use the global logger (and the global logger is designed to be used in parallel). This could introduce a very surprising bug: some unrelated logs could occasionally disappear.
Would it make more sense to move this logic into a main package? If naively moving it up the stack would disable too many logs, could we fix this by inverting control?
image/remote.go
Outdated
| @@ -258,6 +261,8 @@ func (r *remote) Save() (string, error) { | |||
| return "", err | |||
| } | |||
|
|
|||
| log.SetOutput(ioutil.Discard) | |||
| defer log.SetOutput(os.Stdout) | |||
There was a problem hiding this comment.
The default value for the global logger is os.Stderr (and it doesn't appear to be possible to determine the current global io.Writer in the log package). Might be better to use os.Stderr here, but this also makes me feel like pushing this into the main package might be better.
* NOTE: we are silencing the standard logger * all lifecycle phases must create and use their own logger [buildpacks/roadmap#45] Signed-off-by: Emily Casey <[email protected]> Signed-off-by: Danny Joyce <[email protected]>
ekcasey
force-pushed
the
no-more-wall-of-shas
branch
from
b9e1d57 to
b58cbda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[buildpacks/roadmap#45]