Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pack should not create an ephemeral builder if it isn't truly needed #2195

Closed
1 task
natalieparellano opened this issue Jul 2, 2024 · 0 comments · Fixed by #2196
Closed
1 task

pack should not create an ephemeral builder if it isn't truly needed #2195

natalieparellano opened this issue Jul 2, 2024 · 0 comments · Fixed by #2196
Labels
status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Milestone
0.35.0

Comments

@natalieparellano
Copy link
Member

Description

Today, we always create an ephemeral builder, because we assume that it's an inexpensive operation if nothing changed.

When containerd storage is enabled, we can no longer omit base layers for images when saving (see buildpacks/imgutil#222 (comment)). This unfortunately makes creating ephemeral builders expensive. We should only do this when it's absolutely necessary.

Proposed solution

Return the original builder if no buildpacks were added, order was not modified, etc.

Describe alternatives you've considered

Additional context

  • This feature should be documented somewhere
@natalieparellano natalieparellano added type/enhancement Issue that requests a new feature or improvement. status/ready Issue ready to be worked on. labels Jul 2, 2024
@natalieparellano natalieparellano added this to the 0.35.0 milestone Jul 2, 2024
natalieparellano added a commit that referenced this issue Jul 2, 2024
@natalieparellano
Don't create an ephemeral builder if it isn't truly needed
55f7f36 
Fixes #2195

Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano natalieparellano mentioned this issue Jul 2, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.35.0
Development

Successfully merging a pull request may close this issue.

Don't create an ephemeral builder if it isn't truly needed buildpacks/pack
1 participant
@natalieparellano