Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect-image only deserializes fields it requires #415

Merged
merged 1 commit into from
Dec 13, 2019

Conversation

ekcasey
Copy link
Member

@ekcasey ekcasey commented Dec 13, 2019

  • Avoids breaking change due to slice layer metadata

Signed-off-by: Emily Casey [email protected]

* Avoids breaking change due to slice layer metadata

Signed-off-by: Emily Casey <[email protected]>
@ekcasey
Copy link
Member Author

ekcasey commented Dec 13, 2019

Without this PR changes from buildpacks/lifecycle#210 will break pack inspect-image. @elbandito and I decided to deserialize just a subset of fields so the code will be compatible with both metadata schemas.

@ekcasey ekcasey requested a review from jromero December 13, 2019 20:24
Copy link
Member

@jromero jromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for being proactive!

@ekcasey ekcasey merged commit 508158a into master Dec 13, 2019
@ekcasey ekcasey deleted the dont-break-with-slices branch December 13, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants