Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug where DAILY freq gave a compile error #432

Closed
wants to merge 3 commits into from

Conversation

alexthe2
Copy link

The when branch was not exhaustive enough resulting in build errors when building for Android

e: C:\flutter\.pub-cache\hosted\pub.dartlang.org\device_calendar-4.2.0\android\src\main\kotlin\com\builttoroam\devicecalendar\CalendarDelegate.kt: (772, 9): 'when' expression must be exhaustive, add necessary 'DAILY', 'HOURLY', 'MINUTELY', 'SECONDLY' branches or 'else' branch instead

FAILURE: Build failed with an exception.

I have added an else condition throwing an exception to combat this issue:

else -> throw IllegalStateException("Only Freq WEEKLY, MONTHLY or YEARLY acceptable as a rfcRecurrenceRule!")

@alexthe2
Copy link
Author

alexthe2 commented Aug 1, 2022

I now also fixed it, and when it's Daily it adds all Days of the week

@alexthe2 alexthe2 changed the title Fixed bug where it wouldn't build due to Kotlins when restrictions Fixed bug where DAILY freq gave a compile error Aug 1, 2022
@thomassth
Copy link
Contributor

Please rebase the commit, which should solve the build test error.

@thomassth
Copy link
Contributor

Likely solved with #403.

Also not entirely sure what you meant, did not see any build errors like this recently.

@thomassth thomassth closed this Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants