s390x: Add support for inline probestack #9423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uweigand
requested review from
abrown and
alexcrichton
and removed request for
a team
uweigand
force-pushed
the
s390x-probestack
branch
from
4f8b601 to
28c7078
Compare
alexcrichton
approved these changes
Oct 9, 2024
crates/wasmtime/src/config.rs
Outdated
Comment on lines
3024
to
3032
| pub(crate) fn probestack_supported(arch: Architecture) -> bool { | ||
| matches!( | ||
| arch, | ||
| Architecture::X86_64 | Architecture::Aarch64(_) | Architecture::Riscv64(_) | ||
| Architecture::X86_64 | ||
| | Architecture::Aarch64(_) | ||
| | Architecture::Riscv64(_) | ||
| | Architecture::S390x | ||
| ) | ||
| } |
There was a problem hiding this comment.
Mind going ahead and removing this function altogether?
uweigand
force-pushed
the
s390x-probestack
branch
from
28c7078 to
dd3fdac
Compare
This implements the gen_inline_probestack callback in line with the implementation on other platforms, which allows detection of stack overflows with misconfigured hosts. Fixes: bytecodealliance#9396
uweigand
force-pushed
the
s390x-probestack
branch
from
dd3fdac to
24e132e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the gen_inline_probestack callback in line with the implementation on other platforms, which allows detection of stack overflows with misconfigured hosts.
Fixes: #9396