Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(SoM): setOfMarks Overlays unify into setOfMarksOverlays function #82

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

ycjcl868
Copy link
Collaborator

@ycjcl868 ycjcl868 commented Feb 6, 2025

Summary

Combine the three locations of arking position in image, arking position on screen, and arking position during screen recording into a single method call setOfMarksOverlays.

  • Prompt: 问 ChatGPT 今天星期几?
Screen-studio-qKkN3aR6hm.mp4

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 28.72340% with 67 lines in your changes missing coverage. Please review.

Project coverage is 18.71%. Comparing base (ce56f25) to head (ad9d1c3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/main/window/ScreenMarker.ts 0.00% 25 Missing ⚠️
src/renderer/src/hooks/useScreenRecord.ts 0.00% 25 Missing ⚠️
src/main/utils/image.ts 0.00% 6 Missing ⚠️
src/main/shared/setOfMarks.ts 87.09% 0 Missing and 4 partials ⚠️
src/main/store/runAgent.ts 0.00% 3 Missing ⚠️
src/main/window/index.ts 0.00% 3 Missing ⚠️
src/renderer/src/hooks/useStore.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   16.50%   18.71%   +2.21%     
==========================================
  Files          47       48       +1     
  Lines        1218     1218              
  Branches      193      198       +5     
==========================================
+ Hits          201      228      +27     
+ Misses        994      963      -31     
- Partials       23       27       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ycjcl868 ycjcl868 added the bug Something isn't working label Feb 6, 2025
@ycjcl868 ycjcl868 merged commit f795eb3 into main Feb 6, 2025
7 checks passed
@ycjcl868 ycjcl868 deleted the feat-ui-som-unify branch February 6, 2025 11:43
@ycjcl868 ycjcl868 mentioned this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant