Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(test): update github actions #29

Merged
merged 4 commits into from
Feb 25, 2025
Merged

ci(test): update github actions #29

merged 4 commits into from
Feb 25, 2025

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Feb 25, 2025

This PR:

  • Replaces EOL Node 21 in test matrix with Node 22, which is the next LTS
  • Removes Git credentials after checkout as a security precaution by setting persist-credentials to false. They are not used after the initial checkout, and this stops them from accidentally leaking through a script; see related GitHub security post and related actions/checkout issue
  • Bumps GitHub Actions to their latest major versions. Main change is they are now using Node 20 instead of 16, which was EOL as of April 2022:
    • Changelog for actions/checkout can be found here
    • Releases for actions/setup-node can be found here

@c0b41
Copy link
Owner

c0b41 commented Feb 25, 2025

can you also drop node 18, and support node 23

@Fdawgs
Copy link
Contributor Author

Fdawgs commented Feb 25, 2025

can you also drop node 18, and support node 23

Done!

@c0b41 c0b41 merged commit ca9e00d into c0b41:master Feb 25, 2025
9 checks passed
@Fdawgs Fdawgs deleted the patch-1 branch February 26, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants