Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fleet dasbhoards #35

Merged
merged 14 commits into from
Jan 23, 2025
Merged

Feat/fleet dasbhoards #35

merged 14 commits into from
Jan 23, 2025

Conversation

puffitos
Copy link
Member

Motivation

Closes #23 . Review after #34 .

Changes

Added the official rancher dashboards for fleet & the needed "exporters". This will make prometheus scrape fleet metrics and provide us with a couple of new dashboards. A 1% increase in the series capacity was noticed and a slight increase 100MiB in memory.

Tests done

Deployed and tested in a CaaS development cluster. The dashboards aren't that interesting, to be honest. Some metrics seem completely broken (see last 2 screenshots - how can there be no registered clusters...):

image
image
image
image
image

The "broken" dasbhoard and metric:

image
image

The dependencies are already updated, no need to run the command again.
The pinning of the images practically blocked the update of most
components.
Signed-off-by: Bruno Bressi <[email protected]>
This commit adds the necessary templates to be able to parse the rancher
deployments metrics. The resources were copied from the official
rancher-monitoring chart.

The default behavior should be not to activate this monitoring, because
the chart is typically deployed in downstream clusters, which don't have
any rancher deployments.
The dashboards and the "exporter" were copied from the official
rancher-monitoring chart.
Signed-off-by: Bruno Bressi <[email protected]>
@puffitos puffitos added the area/dashboards Issues and PRs regarding the grafana dashboards shipped with the chart. label Jan 22, 2025
@puffitos puffitos added this to the 1.0.0 milestone Jan 22, 2025
@puffitos puffitos self-assigned this Jan 22, 2025
Copy link
Member

@JTaeuber JTaeuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should investigate the exact cause for the broken metrics at some point.
Rest LGTM

@puffitos puffitos merged commit 5d37391 into main Jan 23, 2025
1 check passed
@puffitos puffitos deleted the feat/fleet-dasbhoards branch January 23, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboards Issues and PRs regarding the grafana dashboards shipped with the chart.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fleet dashboards
2 participants