-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local paths in hoogle point to /opt/nix #21
Comments
Okay, I see at NixOS/nix#3212 that it's known that the symlink approach is impure. For now, we can either stop building hoogle databases with this, or make a symlink from /opt/nix to /nix on other machines (where they use the volume approach). This ticket may still have value to you, as it's a concrete example of impurities caused by the symlink approach in haskell builds. |
I'd like to move away from symlink approach, but I'm not sure upstream has come to a better solution yet. Maybe @LnL can jump in :) |
Yeah, I updated that pr to create an apfs volume. Take a look at create-darwin-volume.sh. |
Could someone test with:
before I make a release fixing this? cc @nomeata |
@domenkozar It installed and worked correctly for me. I don't know whether this might be useful to add, but it probably wouldn't hurt (no idea if Spotlight is running on the build machines): In any case, thanks a lot for working on this! |
Yes, works here as well. Thanks! |
Don't forget to switch to @fiadliel thanks for the tip! EDIT: I'll leave it open until release. |
Released |
When hoogle documentation (I'm invoking from haskell.nix) is built with this action, the resulting hoogle database contains paths to /opt/nix instead of /nix. This is the obvious direct culprit 😢
I've only validated this on the MacOS platform, so I'm not certain if it's also true for Linux (but the symlinking appears to be performed on both platforms).
I'll look into whether this is caused inside hoogle, or the hoogle.nix integration, but either way, it's more than concerning that the symlink causes a modified build.
The text was updated successfully, but these errors were encountered: