making VRaptorGsonBuilder a component

[nykolaslima]

We can use VRaptorGsonBuilder to make serialization in "VRaptor way".

e.g.:
vRaptorGsonBuilder.create().toJson(representation);

In order to use VRaptorGsonBuilder in other projects, we need to make it a component to be injected through DI container.

With this changes we are also improving code quality, by receiving VRaptorGsonBuilder as a dependency, removing the responsability of GsonJSONSerialization of build it.

[lucascs]

Why is this a component factory? Why not make VRaptorGsonBuilder a @PrototypeScoped @Component?

Also, please rename VraptorGsonBuilder => VRaptorGsonBuilder

[nykolaslima]

Can we inject a List directly in VRaptorGsonBuilder? How can we create a ExclusionStrategy using the serializee to use in VRaptorGsonBuilder without a component factory?

We can make it @PrototypeScopedlike you said.

[lucascs]

you can put this creation logic inside VRaptorGsonBuilder

[nykolaslima]

@lucascs take a look now =)

If you merge it, can you generate a SNAPSHOT for me?

[lucascs]

you can use createBuilder here

[lucascs]

you still can use createBuilder() ;)

[dipold]

This is cool! Currently I have make a workaround 😞 like this to get an instance of Gson:
Gson gson = new GsonBuilder().registerTypeHierarchyAdapter(Calendar.class, this.calendarISO8601Deserializer).create();

[nykolaslima]

Hey @lucascs, take a look now

[lucascs]

It's missing an @Component here.

[nykolaslima]

Sorry, I missed @Component. Now I believe its ok.

[lucascs]

I'd extract another method here:

JSONSerialization serialization = serializationWithAdapter(new CollectionSerializer());
//...
public JSONSerialization serializationWithAdapter(JsonSerializer adapter) {
    return new GsonJSONSerialization(response, extractor, initializer, createBuilder(adapter), serializee);
}

So we can better express the test intent.

[nykolaslima]

Yes Lucas, I agree with you. I changed it and tests look better. Can you take a look now?

[lucascs]

Thanks!

[nykolaslima]

Can you generate a SNAPSHOT with this, please?

[lucascs]

https://oss.sonatype.org/content/repositories/snapshots/br/com/caelum/vraptor/3.5.2-SNAPSHOT/

[nykolaslima]

Thank you!

[dipold]

@nykolaslima something went wrong here. If I do this:

result.use(json()).from(cliente).include("endereco").serialize();

The class Endereco not longer being serialized =/

[nykolaslima]

Any exception or something?

[dipold]

Nothing..

[nykolaslima]

@dipold I have made a test with this situation that you exposes but here the serialization works fine.

Are you using Gson serialization?

[lucascs]

We have tests for this... maybe the problem is that Serializee is a component now =(

[dipold]

I created a new project to be sure about the problem. And the problem persists.

What I found in debug mode, at the moment, is that VRaptorGsonBuilder and GsonJSONSerialization receive different instances of Serializee.

And that does not happen in units tests. I tried to create a unit test without success.

My project configuration:
web.xml

<context-param>
    <param-name>br.com.caelum.vraptor.packages</param-name>
        <param-value>
            br.com.caelum.vraptor.serialization.gson,
            br.com.caelum.vraptor.deserialization.gson
        </param-value>
</context-param>

controller:

@Get("/clientes")
public void get() {
    List<Cliente> clientes = new ArrayList<Cliente>();
    Endereco e1 = new Endereco(1L, "Logradouro 1");
    Cliente c1 = new Cliente(1L, "Nome 1", e1);
    clientes.add(c1);
    result.use(Results.json()).withoutRoot().from(clientes).include("endereco").serialize();
}

[lucascs]

Try again please with this snapshot:
https://oss.sonatype.org/content/repositories/snapshots/br/com/caelum/vraptor/3.5.2-SNAPSHOT/vraptor-3.5.2-20130816.151159-10.jar

[dipold]

Thanks @lucascs
Works like a charm

[dipold]

I think there's one more thing to fix.
The class HibernateProxySerializer should not be adapted to use the new VRaptorGsonBuilder?
Because the class HibernateProxySerializer is invoked but is not serializing to the correct instance of Gson, see:
return new Gson().toJsonTree(deProxied);

[lucascs]

What is the result of this?

[dipold]

The final operation result an exception:
java.lang.UnsupportedOperationException: Attempted to serialize java.lang.Class:
org.hibernate.proxy.HibernateProxy. Forgot to register a type adapter?

But the HibernateProxySerializer run ok:

[lucascs]

But estado and microRegiao are proxies...

I think that is why it is throwing the exception...

can't you delegate the serialization instead of calling new Gson().toJsonTree?
It is not using all registered adapters.

[dipold]

You are right!

How I can delegate? I tried change the code to bellow and now works fine:

return ctx.serialize(deProxied);//new Gson().toJsonTree(deProxied);

I think we can do it, given that ctx never invoke on the src object itself since that will cause an infinite loop.

[lucascs]

Change this and send a Pull request please =)