Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate single kernel #541

Merged
merged 9 commits into from
Feb 12, 2025
Merged

Conversation

Gu1nness
Copy link
Contributor

Issue

Needs to integrate the new refactoring using the single kernel charm

Solution

Integrate the single kernel library

@Gu1nness Gu1nness force-pushed the feat/integrate-single-kernel branch from 15d998a to 2e10e33 Compare January 30, 2025 15:55
@Gu1nness Gu1nness force-pushed the feat/integrate-single-kernel branch 2 times, most recently from fa6f302 to 56e10b9 Compare February 7, 2025 14:29
@Gu1nness Gu1nness changed the title WIP: Integrate single kernel feat: Integrate single kernel Feb 7, 2025
@Gu1nness Gu1nness marked this pull request as ready for review February 7, 2025 15:58
Copy link
Collaborator

@MiaAltieri MiaAltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work Neha! you should be proud

operator_type = MongoDBOperator
substrate = Substrates.VM
peer_rel_name = PeerRelationNames.PEERS
name = "mongodb"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incredible

Mehdi-Bendriss
Mehdi-Bendriss previously approved these changes Feb 10, 2025
Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very happy with how things turned out!

@Gu1nness Gu1nness dismissed Mehdi-Bendriss’s stale review February 10, 2025 15:42

The merge-base changed after approval.

@Gu1nness Gu1nness force-pushed the feat/integrate-single-kernel branch from 90b73f0 to 99c3d89 Compare February 10, 2025 15:42
MiaAltieri
MiaAltieri previously approved these changes Feb 12, 2025
@Mehdi-Bendriss Mehdi-Bendriss merged commit dfeb7f0 into 6/edge Feb 12, 2025
33 checks passed
@Mehdi-Bendriss Mehdi-Bendriss deleted the feat/integrate-single-kernel branch February 12, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants