[DPE-3184] Update secrets implementation #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
commented
Feb 5, 2024
pyproject.toml
Outdated
There was a problem hiding this comment.
Missed the linter configs when ruff was updated
dragomirp
commented
Feb 5, 2024
Comment on lines
-240
to
-253
|
|
||
| def add_user(self, username: str, password: str): | ||
| """Adds user to app databag.""" | ||
| if not self.charm.unit.is_leader(): | ||
| return | ||
|
|
||
| self.charm.set_secret(APP_SCOPE, username, password) | ||
|
|
||
| def remove_user(self, username: str): | ||
| """Removes user from app databag.""" | ||
| if not self.charm.unit.is_leader(): | ||
| return | ||
|
|
||
| self.charm.set_secret(APP_SCOPE, username, None) |
There was a problem hiding this comment.
Removing arbitrary secret fields as with the k8s charm
taurus-forever
approved these changes
Feb 5, 2024
juditnovak
approved these changes
Feb 6, 2024
src/charm.py
Outdated
| else: | ||
| del self.peers.app_databag[key] | ||
| self.peer_relation_unit.delete_relation_data(peers.id, [secret_key]) |
There was a problem hiding this comment.
I really should have introduced a
def peer_relation_data(scope: Scope) -> DataPeer:
if scope == APP_SCOPE:
return self.peer_relation_app
elif scope == APP_UNIT:
return self.peer_relation_unit
function, to turn the above (repetitive) structure to
self.peer_relation_data(scope).delete_relation_data(peers.id, [secret_key])
If you've got the capacity, don't U wanna do that? If not, of course feel free to ignore (it's cosmetics)
juditnovak
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update peer secrets implementation to be up to date with other PG charms