[DPE-3535] Rerender config from secrets during upgrade #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taurus-forever
approved these changes
Feb 9, 2024
dragomirp
commented
Feb 10, 2024
Comment on lines
+87
to
+88
| cfg = self.charm.get_secret(APP_SCOPE, CFG_FILE_DATABAG_KEY) | ||
| self.charm.render_utility_files(cfg) |
There was a problem hiding this comment.
We need the cfg from the secret, since otherwise the follower units will get stuck during refresh.
dragomirp
commented
Feb 10, 2024
Comment on lines
+143
to
+144
| if not cfg_file: | ||
| cfg_file = pgb.DEFAULT_CONFIG |
There was a problem hiding this comment.
The peer rel is not yet around when the charm initialises, so we need to use the default
marceloneppel
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update rendered a blank config and relied on perpetual peer changed to refresh the configs.