generated from canonical/template-operator
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-3658] Add subordinate charms test #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b05087
to
c288319
Compare
dragomirp
commented
Mar 30, 2024
Comment on lines
-47
to
-61
async def get_unit_address(ops_test: OpsTest, application_name: str, unit_name: str) -> str: | ||
"""Get unit IP address. | ||
|
||
Args: | ||
ops_test: The ops test framework instance | ||
application_name: The name of the application | ||
unit_name: The name of the unit | ||
|
||
Returns: | ||
IP address of the unit | ||
""" | ||
status = await ops_test.model.get_status() | ||
return status["applications"][application_name].units[unit_name]["address"] | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dead code
marceloneppel
approved these changes
Mar 30, 2024
Co-authored-by: Marcelo Henrique Neppel <[email protected]>
taurus-forever
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! BTW, consider to copy Landscape client tests from mysql-router.
Oups.. all here, just different approach. All good. Tnx!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy subordinate charms test from the Postgresql VM charm.