Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-3658] Add subordinate charms test #195

Merged
merged 8 commits into from
Apr 2, 2024
Merged

[DPE-3658] Add subordinate charms test #195

merged 8 commits into from
Apr 2, 2024

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Mar 26, 2024

Copy subordinate charms test from the Postgresql VM charm.

@dragomirp dragomirp force-pushed the dpe-3658 branch 2 times, most recently from 8b05087 to c288319 Compare March 26, 2024 15:37
Comment on lines -47 to -61
async def get_unit_address(ops_test: OpsTest, application_name: str, unit_name: str) -> str:
"""Get unit IP address.

Args:
ops_test: The ops test framework instance
application_name: The name of the application
unit_name: The name of the unit

Returns:
IP address of the unit
"""
status = await ops_test.model.get_status()
return status["applications"][application_name].units[unit_name]["address"]


Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code

@dragomirp dragomirp marked this pull request as ready for review March 30, 2024 14:14
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! BTW, consider to copy Landscape client tests from mysql-router.

Oups.. all here, just different approach. All good. Tnx!

@dragomirp dragomirp merged commit d3b61ba into main Apr 2, 2024
34 checks passed
@dragomirp dragomirp deleted the dpe-3658 branch April 2, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants