[DPE-1454] Update database ownership #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
requested review from
marceloneppel,
taurus-forever and
lucasgameiroborges
src/relations/pgbouncer_provider.py
Outdated
Comment on lines
200
to
202
| delete_db = database not in dbs.values() | ||
| if database and delete_db: | ||
| self.charm.backend.remove_auth_function(dbs=[database]) |
There was a problem hiding this comment.
Similar to the K8s PR, it seems that the auth_function is not being removed correctly.
juju deploy postgresql --channel 14/edge
juju deploy ./pgbouncer_ubuntu-22.04-amd64.charm
juju deploy data-integrator app1
juju relate pgbouncer postgresql
juju config app1 database-name=test
juju relate app1 pgbouncer
juju run postgresql/leader get-password
psql "host={postgresql-unit-ip} user=operator dbname=test password={password}”
# Run SELECT specific_schema FROM information_schema.routines WHERE routine_name='get_auth'; which outputs pgbouncer_auth_relation_7.
juju run app1/leader get-credentials
psql "host={ip-from-get-credentials} user={user-from-get-credentials} dbname={database-name-from-get-credentials} password={password-from-get-credentials}”
# The connection works.
juju remove-relation app1 pgbouncer
psql "host={postgresql-unit-ip} user=operator dbname=test password={password}”
# Run SELECT specific_schema FROM information_schema.routines WHERE routine_name='get_auth'; which still outputs pgbouncer_auth_relation_7.There was a problem hiding this comment.
This is unfortunately more complicated case than k8s, since the cleanup hooks are unreliable due to subordination. There's DPE-3948 to try to make things more consistent.
marceloneppel
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Cannot drop db objects when rerelating to pgbouncer
Solution
Port of canonical/pgbouncer-k8s-operator#287