[MISC] Move scheduled tests #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dragomirp
commented
Jul 22, 2024
•
dragomirp
commented
- Revert scheduled test move
- Update charm libs
- Fix for transient model error seen in CI
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
==========================================
+ Coverage 71.35% 71.47% +0.11%
==========================================
Files 7 7
Lines 1201 1206 +5
Branches 211 211
==========================================
+ Hits 857 862 +5
Misses 266 266
Partials 78 78 ☔ View full report in Codecov by Sentry. |
dragomirp
commented
Jul 22, 2024
Comment on lines
+175
to
+178
| except ModelError: | ||
| event.defer() | ||
| logger.error("deferring database-created hook - cannot access secrets") | ||
| return |
There was a problem hiding this comment.
Seen it on occasion in CI: https://github.com/canonical/pgbouncer-operator/actions/runs/10021732870/job/27700959925#step:28:7580
There was a problem hiding this comment.
Good to mention this in PR description.
dragomirp
requested review from
taurus-forever,
marceloneppel and
lucasgameiroborges
taurus-forever
approved these changes
Jul 22, 2024
Comment on lines
+175
to
+178
| except ModelError: | ||
| event.defer() | ||
| logger.error("deferring database-created hook - cannot access secrets") | ||
| return |
There was a problem hiding this comment.
Good to mention this in PR description.
marceloneppel
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.