-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Stop tracking channel for held snaps #384
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
=======================================
Coverage 74.50% 74.50%
=======================================
Files 9 9
Lines 1322 1322
Branches 228 228
=======================================
Hits 985 985
Misses 262 262
Partials 75 75 ☔ View full report in Codecov by Sentry. |
Huh, just realized this is going to break the automation for pinning snap revs in bundles :( Question: Will the channel be specified anywhere else in the charm code? Will there be any other "source of truth" for the channel of the snap? Wondering if I can avoid hard-coding it in the workflow. |
Technically the channel stated is wrong, there's no revisions in it ATM. We can set the correct risk (14/edge and 1/edge), but then we can't change it when releasing a charm revision to stable. Is the revision itself not enough for store pinning to work? |
Follow MySQL approach for now: https://github.com/canonical/data-platform-workflows/blob/main/python/cli/data_platform_workflows_cli/update_bundle.py#L121 |
…resql` and `charmed_pgbouncer` (#241) With the merge of canonical/postgresql-operator#638 and canonical/pgbouncer-operator#384, the workflow cannot rely on charm's source code to fetch the snap channel info.
Remove tracking of snap channel for the charmed-postgresql snap