snapcraft.yaml: fix missing primed packages in manifest #15029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboozzoo
reviewed
Feb 5, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15029 +/- ##
=========================================
Coverage ? 78.27%
=========================================
Files ? 1156
Lines ? 154329
Branches ? 0
=========================================
Hits ? 120806
Misses ? 26095
Partials ? 7428
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The attributes are there, but the manifest is still not correct. I will have to debug a bit deeper into this. |
|
Depends also on https://bugs.launchpad.net/snapcraft/+bug/2097440 |
valentindavid
force-pushed
the
valentindavid/missing-manifest-stage-packages
branch
from
7910805 to
a4b4942
Compare
|
Mon Feb 17 12:18:08 UTC 2025 Failures:Preparing:
Executing:
Restoring:
|
valentindavid
force-pushed
the
valentindavid/missing-manifest-stage-packages
branch
from
a4b4942 to
501bd34
Compare
|
I have done a work-around for https://bugs.launchpad.net/snapcraft/+bug/2097440 |
valentindavid
force-pushed
the
valentindavid/missing-manifest-stage-packages
branch
3 times, most recently
from
9bce881 to
da06a76
Compare
valentindavid
force-pushed
the
valentindavid/missing-manifest-stage-packages
branch
from
da06a76 to
b1661dd
Compare
|
Adding this to 2.68.1, there is a customer waiting for this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was initiated by a conversation started by Iseoluwa Titiloye https://chat.canonical.com/canonical/pl/qpo9iy53z3fudkbdj4akdnteth
Related to: https://bugs.launchpad.net/snapcraft/+bug/2097440