Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secboot: bump secboot to rev e07f4ae48e98 #15127

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

bboozzoo
Copy link
Contributor

Bump secboot to include a fix from
canonical/secboot#384

@bboozzoo bboozzoo added the Run nested The PR also runs tests inluded in nested suite label Feb 25, 2025
@bboozzoo bboozzoo added this to the 2.68.2 milestone Feb 25, 2025
Copy link
Collaborator

@ernestl ernestl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ernestl ernestl removed the request for review from valentindavid February 25, 2025 14:47
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (a272aac) to head (4a58c03).
Report is 70 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15127      +/-   ##
==========================================
- Coverage   78.07%   77.84%   -0.23%     
==========================================
  Files        1182     1171      -11     
  Lines      157743   157064     -679     
==========================================
- Hits       123154   122272     -882     
- Misses      26943    27185     +242     
+ Partials     7646     7607      -39     
Flag Coverage Δ
unittests 77.84% <100.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@chrisccoulson chrisccoulson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

Copy link

github-actions bot commented Feb 25, 2025

Wed Feb 26 16:08:12 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/13538262741

Failures:

Preparing:

  • openstack:fedora-40-64:tests/regression/
  • openstack:fedora-40-64:tests/completion/
  • openstack:fedora-40-64:tests/main/
  • google-nested:ubuntu-24.04-64:tests/nested/manual/hybrid-remodel
  • google-nested:ubuntu-24.04-64:tests/nested/manual/hybrid-fde-dbx
  • google-nested:ubuntu-24.04-64:tests/nested/manual/hybrid-fde-dbx
  • google-nested:ubuntu-24.04-64:tests/nested/manual/hybrid-remodel
  • openstack:opensuse-tumbleweed-64

Executing:

  • openstack:centos-9-64:tests/main/degraded
  • openstack:debian-12-64:tests/main/progress
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller
  • google-nested:ubuntu-24.04-64:tests/nested/manual/split-refresh
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:encrypted
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:seeded
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:plain
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:partial
  • google-nested:ubuntu-24.04-64:tests/nested/manual/core20-remodel
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller
  • google-nested:ubuntu-24.04-64:tests/nested/manual/split-refresh
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:encrypted
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:seeded
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:partial
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:plain
  • google-nested:ubuntu-24.04-64:tests/nested/manual/core20-remodel
  • google:ubuntu-25.04-64:tests/main/cgroup-devices-v2
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-helper
  • google:ubuntu-25.04-64:tests/main/snap-ns-forward-compat
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-serial-port
  • google:ubuntu-25.04-64:tests/main/snap-user-service-socket-activation
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups:kmsg
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-required-or-optional
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-strict-enforced
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups:uinput
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-self-manage

Restoring:

  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-strict-enforced

Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Bump secboot to include a fix from
canonical/secboot#384

Signed-off-by: Maciej Borzecki <[email protected]>
@bboozzoo bboozzoo force-pushed the bboozzoo/secboot-bump branch from 8b4e3a6 to 4a58c03 Compare February 26, 2025 06:58
@ernestl
Copy link
Collaborator

ernestl commented Feb 26, 2025

Note: google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller* and google-nested:ubuntu-24.04-64:tests/nested/manual/hybrid* tests issues was addressed with #15125. Prefer not to rebase at this stage in the interest of time for release 2.68.2.

@ernestl ernestl merged commit 4211a2d into canonical:master Feb 26, 2025
70 of 78 checks passed
ernestl pushed a commit to ernestl/snapd that referenced this pull request Feb 26, 2025
* go.mod: bump secboot to rev e07f4ae48e98

Bump secboot to include a fix from
canonical/secboot#384

Signed-off-by: Maciej Borzecki <[email protected]>

* secboot: update to match canonical/secboot API changes

Signed-off-by: Maciej Borzecki <[email protected]>

---------

Signed-off-by: Maciej Borzecki <[email protected]>
@ernestl ernestl mentioned this pull request Feb 26, 2025
ernestl pushed a commit that referenced this pull request Feb 28, 2025
* go.mod: bump secboot to rev e07f4ae48e98

Bump secboot to include a fix from
canonical/secboot#384

Signed-off-by: Maciej Borzecki <[email protected]>

* secboot: update to match canonical/secboot API changes

Signed-off-by: Maciej Borzecki <[email protected]>

---------

Signed-off-by: Maciej Borzecki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked Run nested The PR also runs tests inluded in nested suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants