tests/lib/tools/tests.invariant: look for unexpected snap cgroups #15145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snap cgroups should be cleaned up as a result of removing the snaps during restore. Signed-off-by: Maciej Borzecki <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15145 +/- ##
==========================================
- Coverage 78.07% 78.06% -0.01%
==========================================
Files 1182 1184 +2
Lines 157743 158251 +508
==========================================
+ Hits 123154 123540 +386
- Misses 26943 27030 +87
- Partials 7646 7681 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zyga
reviewed
Feb 27, 2025
| n="$1" # invariant name | ||
| find /sys/fs/cgroup -type d -name 'snap.*' -ls > "$TESTSTMP/tests.invariant.$n" | ||
| if [ -s "$TESTSTMP/tests.invariant.$n" ]; then | ||
| echo "tests.invariant: leftover cgroup scope files" >&2 |
There was a problem hiding this comment.
Suggested change
| echo "tests.invariant: leftover cgroup scope files" >&2 | |
| echo "tests.invariant: leftover snap cgroups" >&2 |
|
Thu Feb 27 12:05:25 UTC 2025 Failures:Preparing:
Executing:
Restoring:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snap cgroups should be cleaned up as a result of removing the snaps during restore.
Related: SNAPDENG-34419
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?