Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add feature tagging workflow #15148

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

maykathm
Copy link
Contributor

@maykathm maykathm commented Feb 27, 2025

Dependent on feature tag logging in #15091

This adds the ability to generate feature tags for a spread run in two ways:

  • Using the workflow dispatch in the new Feature Tagging workflow
  • Pushing on master (will only tag spread tests that have been changed)
  • Using run-spread with SPREAD_TAG_FEATURES set

Both methods permit automatically rerunning spread and consolidating the ending results into system-by-system json files of features. In the workflow, the results are uploaded as an artifact, though this is a temporary measure since in the future the tags will instead be loaded into a DB elsewhere.

Both the run-spread additions and the workflow contain a rerunning mechanism to automatically rerun spread with the failed tests a maximum number of times. Once the workflow/run-spread script has finished all spread runs, including reruns, it will consolidate the feature tagging results into a single final json file for each system. It consolidates results by creating a final version with all tests run where more recent individual test results substitute the less recent.

@maykathm maykathm added the Skip spread Indicate that spread job should not run label Feb 27, 2025
Copy link

github-actions bot commented Feb 27, 2025

Fri Feb 28 16:30:17 UTC 2025

Spread tests skipped

@maykathm maykathm force-pushed the SNAPDENG-34441-add-feature-tagging-workflow branch 2 times, most recently from 3d46364 to 34ed733 Compare February 28, 2025 15:49
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.11%. Comparing base (a272aac) to head (44ba42a).
Report is 77 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15148      +/-   ##
==========================================
+ Coverage   78.07%   78.11%   +0.04%     
==========================================
  Files        1182     1176       -6     
  Lines      157743   158147     +404     
==========================================
+ Hits       123154   123542     +388     
+ Misses      26943    26931      -12     
- Partials     7646     7674      +28     
Flag Coverage Δ
unittests 78.11% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maykathm maykathm force-pushed the SNAPDENG-34441-add-feature-tagging-workflow branch from 34ed733 to 44ba42a Compare February 28, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip spread Indicate that spread job should not run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant