-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add charm architecture documentation #19
Conversation
Hi @yanksyoon , can you please do a technical (not stylistic) review? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the documentation, LGTM!
Im also wondering how detailed the scope of the documentation should be (e.g. should we describe why its a machine charm running docker containers, what type of fingerprints are generated...etc), the current scope looks fine to me though.
@yanksyoon I think specific reasons why it is a machine charm could be included. Can you tell us the reasoning behind design decisions in the past? I assume a k8s charm would be more difficult to implement in terms of ingress via ssh ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding architecture documentation! It looks great to me 🎉
Co-authored-by: Erin Conley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few remaining details and then we should be good to go :)
Co-authored-by: Erin Conley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the architecture documentation and diagram!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Applicable spec:
Overview
Add charm architecture documentation
Checklist
src-docs
urgent
,trivial
,complex
)