Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add charm architecture documentation #19

Merged
merged 8 commits into from
Feb 20, 2025

Conversation

cbartz
Copy link
Collaborator

@cbartz cbartz commented Feb 17, 2025

Applicable spec:

Overview

Add charm architecture documentation

Checklist

@cbartz cbartz added the documentation Improvements or additions to documentation label Feb 17, 2025
@cbartz cbartz requested a review from yanksyoon February 17, 2025 10:38
@cbartz
Copy link
Collaborator Author

cbartz commented Feb 17, 2025

Hi @yanksyoon , can you please do a technical (not stylistic) review? Thanks.

yanksyoon
yanksyoon previously approved these changes Feb 18, 2025
Copy link
Member

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the documentation, LGTM!
Im also wondering how detailed the scope of the documentation should be (e.g. should we describe why its a machine charm running docker containers, what type of fingerprints are generated...etc), the current scope looks fine to me though.

@cbartz
Copy link
Collaborator Author

cbartz commented Feb 18, 2025

Thanks for the documentation, LGTM! Im also wondering how detailed the scope of the documentation should be (e.g. should we describe why its a machine charm running docker containers, what type of fingerprints are generated...etc), the current scope looks fine to me though.

@yanksyoon I think specific reasons why it is a machine charm could be included. Can you tell us the reasoning behind design decisions in the past? I assume a k8s charm would be more difficult to implement in terms of ingress via ssh ?

Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding architecture documentation! It looks great to me 🎉

@cbartz cbartz marked this pull request as ready for review February 19, 2025 08:24
@cbartz cbartz requested a review from a team as a code owner February 19, 2025 08:24
@cbartz cbartz requested review from alithethird, jdkandersson, yanksyoon and erinecon and removed request for alithethird and jdkandersson February 19, 2025 08:24
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few remaining details and then we should be good to go :)

@cbartz cbartz requested a review from erinecon February 19, 2025 13:15
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the architecture documentation and diagram!

Copy link
Member

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@cbartz cbartz merged commit a9f0e47 into main Feb 20, 2025
18 checks passed
@cbartz cbartz deleted the docs/charm-architecture-ISD-2898 branch February 20, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Libraries: Out of sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants