-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intel NUC desktop rebrand #13570
Intel NUC desktop rebrand #13570
Conversation
Demo starting at https://ubuntu-com-13570.demos.haus/download/intel-nuc-desktop |
d116d99
to
62d5ade
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## download-bubble-wd-8482 #13570 +/- ##
========================================================
Coverage 74.41% 74.41%
========================================================
Files 107 107
Lines 2838 2838
Branches 946 946
========================================================
Hits 2112 2112
Misses 702 702
Partials 24 24 |
94f00ec
to
8902c8e
Compare
The sections under "Next steps" don't exist on the live version, so please remove. I've adjusted the copy doc accordingly, please flag this up when it happens. The form and the footer are missing, can you please incorporate them before I do a full review? Thank you. |
d47af01
to
0dc4412
Compare
18d9b3e
to
27bbc38
Compare
UX+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a couple of minor changes
6256de0
to
d51b66b
Compare
d51b66b
to
4ce4189
Compare
Checked, this isn't changing templates/download/intel-iei-tank-870.html, so merging. |
daf79af
into
canonical:download-bubble-wd-8482
QA
Issue / Card
Fixes https://ubuntu-com-13570.demos.haus/
Screenshots
Help
QA steps - Commit guidelines