-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD-9167 Rebrand server power #13678
WD-9167 Rebrand server power #13678
Conversation
Demo starting at https://ubuntu-com-13678.demos.haus |
3b90702
to
84eece0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## download-bubble-wd-8482 #13678 +/- ##
========================================================
Coverage 74.49% 74.49%
========================================================
Files 107 107
Lines 2854 2854
Branches 954 954
========================================================
Hits 2126 2126
Misses 704 704
Partials 24 24 |
18cf4a7
to
390fedd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some suggestions
390fedd
to
c513684
Compare
dc1e5b4
to
f79c007
Compare
The spacing above and below the "Ubuntu Server" section doesn't match the mockup, and I think that affects the sense of hierarchy, please fix. Little change: please adjust the two CTA as per the copy (drop "Ubuntu" from them). I also left a couple minor comments in the code. |
c1b9e83
to
2f68910
Compare
Spacing still seems a bit excessive on top of the Ubuntu Server section compared to the mockup, but there's better hierarchy now and it's a visual matter anyway, so UX+1. |
@juanruitina That spacing was suggested by @lyubomir-popov #13678 (comment) Looks like after I refactored for the medium screens that space seems to be redundant, removed. |
26382c6
to
d6104b2
Compare
ce68dae
to
d364153
Compare
d364153
to
3077bed
Compare
templates/download/server/power.html
Outdated
<div class="col-10"> | ||
<section class="p-strip is-shallow u-no-padding--bottom"> | ||
<div class="row--50-50 p-section--shallow"> | ||
<div class="col"> | ||
<h1>Ubuntu Server for IBM POWER</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This heading is in 2 lines in design, so maybe add a br
QA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-9164
Screenshots
Help
QA steps - Commit guidelines