Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-9167 Rebrand server power #13678

Merged

Conversation

carkod
Copy link
Contributor

@carkod carkod commented Mar 18, 2024

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-9164

Screenshots


power

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13678.demos.haus

@carkod carkod marked this pull request as draft March 18, 2024 16:59
@carkod carkod force-pushed the rebrand-server-power-wd-9167 branch 2 times, most recently from 3b90702 to 84eece0 Compare March 18, 2024 17:05
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.49%. Comparing base (f79c007) to head (39a726c).
Report is 1 commits behind head on download-bubble-wd-8482.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           download-bubble-wd-8482   #13678   +/-   ##
========================================================
  Coverage                    74.49%   74.49%           
========================================================
  Files                          107      107           
  Lines                         2854     2854           
  Branches                       954      954           
========================================================
  Hits                          2126     2126           
  Misses                         704      704           
  Partials                        24       24           

@carkod carkod force-pushed the rebrand-server-power-wd-9167 branch 3 times, most recently from 18cf4a7 to 390fedd Compare March 19, 2024 09:31
@carkod carkod marked this pull request as ready for review March 19, 2024 12:01
Copy link
Contributor

@lyubomir-popov lyubomir-popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions

@lyubomir-popov
Copy link
Contributor

image
Can we indent h5s one column on medium screens? col-start-medium-2 col-medium-2 should do it

@juanruitina
Copy link
Contributor

juanruitina commented Mar 20, 2024

The spacing above and below the "Ubuntu Server" section doesn't match the mockup, and I think that affects the sense of hierarchy, please fix.

Little change: please adjust the two CTA as per the copy (drop "Ubuntu" from them). I also left a couple minor comments in the code.

@carkod carkod force-pushed the rebrand-server-power-wd-9167 branch 2 times, most recently from c1b9e83 to 2f68910 Compare March 20, 2024 10:12
@juanruitina
Copy link
Contributor

juanruitina commented Mar 20, 2024

Spacing still seems a bit excessive on top of the Ubuntu Server section compared to the mockup, but there's better hierarchy now and it's a visual matter anyway, so UX+1.

@carkod
Copy link
Contributor Author

carkod commented Mar 20, 2024

The spacing above and below the "Ubuntu Server" section doesn't match the mockup, and I think that affects the sense of hierarchy, please fix.

Little change: please adjust the two CTA as per the copy (drop "Ubuntu" from them). I also left a couple minor comments in the code.

@juanruitina That spacing was suggested by @lyubomir-popov #13678 (comment)

Looks like after I refactored for the medium screens that space seems to be redundant, removed.

@carkod carkod force-pushed the rebrand-server-power-wd-9167 branch 2 times, most recently from 26382c6 to d6104b2 Compare March 20, 2024 11:13
@carkod carkod force-pushed the rebrand-server-power-wd-9167 branch 2 times, most recently from ce68dae to d364153 Compare March 20, 2024 11:22
@carkod carkod force-pushed the rebrand-server-power-wd-9167 branch from d364153 to 3077bed Compare March 20, 2024 11:24
<div class="col-10">
<section class="p-strip is-shallow u-no-padding--bottom">
<div class="row--50-50 p-section--shallow">
<div class="col">
<h1>Ubuntu Server for IBM POWER</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This heading is in 2 lines in design, so maybe add a br

@carkod carkod merged commit 3b5d63e into canonical:download-bubble-wd-8482 Mar 22, 2024
14 checks passed
@carkod carkod deleted the rebrand-server-power-wd-9167 branch March 22, 2024 13:46
akbarkz pushed a commit that referenced this pull request Apr 1, 2024
akbarkz pushed a commit that referenced this pull request Apr 8, 2024
mtruj013 pushed a commit to mtruj013/ubuntu.com that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants