-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security OSV page #14765
Security OSV page #14765
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature-security-bubble #14765 +/- ##
========================================================
Coverage 72.32% 72.32%
========================================================
Files 120 120
Lines 3404 3404
Branches 1174 1174
========================================================
Hits 2462 2462
Misses 917 917
Partials 25 25 |
Thank you @goulinkh ! For "What types of Ubuntu OSV data are available?" and "Where can I get OSV data?":
![]() For "More resources":
All else is good, thank you! |
Hi @mattea-turic, I've applied the suggested changes. Let me know if there is any other comments. |
Looks good! +1ing @goulinkh |
Thank you, looks pretty much perfect @goulinkh! Some super minor comments:
|
Thanks for looking into this @eliman11, I've applied the suggested changes. |
Thanks for the quick changes, @goulinkh! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple minor comments.
I have also left a comment in the doc for @eliman11 regarding the 'Vulnerability management in Ubuntu' link as I don't think it makes sense to include it
Hi @petesfrench , thanks for the code review! Let me know if this is good to go. |
</div> | ||
</section> | ||
|
||
<section class="p-section--deep"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe this comment is saying to remove this section, as it is still missing a link
292b226
into
canonical:feature-security-bubble
* add security OSV page * update image asset * fix spacing * copy doc fixes * apply code fixes * refactor: Remove unlinked resource in resource section --------- Co-authored-by: Peter French <[email protected]>
Done
Add Security OSV page
QA
Issue / Card
Fixes WD-18848
Help
QA steps - Commit guidelines