Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security OSV page #14765

Merged

Conversation

goulinkh
Copy link
Contributor

@goulinkh goulinkh commented Feb 19, 2025

Done

Add Security OSV page

QA

Issue / Card

Fixes WD-18848

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.32%. Comparing base (01eeb4d) to head (385bef9).
Report is 15 commits behind head on feature-security-bubble.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature-security-bubble   #14765   +/-   ##
========================================================
  Coverage                    72.32%   72.32%           
========================================================
  Files                          120      120           
  Lines                         3404     3404           
  Branches                      1174     1174           
========================================================
  Hits                          2462     2462           
  Misses                         917      917           
  Partials                        25       25           

@goulinkh goulinkh changed the base branch from main to feature-security-bubble February 19, 2025 18:26
@mattea-turic
Copy link
Collaborator

Thank you @goulinkh !

For "What types of Ubuntu OSV data are available?" and "Where can I get OSV data?":

  • It looks like you've layered the right columns with extra padding – could you pls remove these so that there's just the p-section padding-bottom?
Screenshot 2025-02-20 at 11 48 40

For "More resources":

  • Could you use deep bottom padding here pls?

All else is good, thank you!

@goulinkh
Copy link
Contributor Author

Hi @mattea-turic, I've applied the suggested changes. Let me know if there is any other comments.

@mattea-turic
Copy link
Collaborator

Looks good! +1ing @goulinkh

@eliman11
Copy link

Thank you, looks pretty much perfect @goulinkh! Some super minor comments:

@goulinkh
Copy link
Contributor Author

Thanks for looking into this @eliman11, I've applied the suggested changes.

@eliman11
Copy link

Thanks for the quick changes, @goulinkh!

@petesfrench petesfrench self-assigned this Feb 24, 2025
Copy link
Contributor

@petesfrench petesfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple minor comments.

I have also left a comment in the doc for @eliman11 regarding the 'Vulnerability management in Ubuntu' link as I don't think it makes sense to include it

@goulinkh goulinkh requested a review from petesfrench February 27, 2025 11:50
@goulinkh
Copy link
Contributor Author

Hi @petesfrench , thanks for the code review! Let me know if this is good to go.

</div>
</section>

<section class="p-section--deep">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe this comment is saying to remove this section, as it is still missing a link

@petesfrench petesfrench merged commit 292b226 into canonical:feature-security-bubble Feb 28, 2025
12 checks passed
mtruj013 pushed a commit that referenced this pull request Feb 28, 2025
* add security OSV page

* update image asset

* fix spacing

* copy doc fixes

* apply code fixes

* refactor: Remove unlinked resource in resource section

---------

Co-authored-by: Peter French <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants