Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: /security/esm refresh #14795

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

mtruj013
Copy link
Contributor

@mtruj013 mtruj013 commented Feb 26, 2025

Done

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-12043

@webteam-app
Copy link

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.32%. Comparing base (6ece7e1) to head (f658a19).
Report is 7 commits behind head on feature-security-bubble.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature-security-bubble   #14795   +/-   ##
========================================================
  Coverage                    72.32%   72.32%           
========================================================
  Files                          120      120           
  Lines                         3404     3404           
  Branches                      1174     1177    +3     
========================================================
  Hits                          2462     2462           
  Misses                         917      917           
  Partials                        25       25           

@mattea-turic
Copy link
Collaborator

mattea-turic commented Feb 27, 2025

Thank you @mtruj013 !

For "Available for every Ubuntu LTS":

  • Could the images be hidden on mobile pls?

For "Ubuntu security maintenance schedule":

  • I think there may have been additional changes in the copydoc that I added to the Figma file, which includes this chart (scroll a little down on the page) and a different table

For "What our customers say"

  • Is the "All the success stories" CTA something we're doing for quote sections now, as it's not something in the copydoc

@mtruj013
Copy link
Contributor Author

Thanks @mattea-turic, addressed all comments

Is the "All the success stories" CTA something we're doing for quote sections now, as it's not something in the copydoc

It was originally there, I just forgot to remove it, but good opportunity to highlight this discussion!

@mattea-turic
Copy link
Collaborator

mattea-turic commented Feb 27, 2025

@mtruj013 thanks for your patience with this one!! LGTM :)

Just one small thing (I'll +1 anyways), could this shallow be removed when the chart is hidden? i.e. on mobile
Screenshot 2025-02-27 at 16 09 02

@mtruj013 mtruj013 merged commit e861874 into canonical:feature-security-bubble Feb 28, 2025
14 of 15 checks passed
@mtruj013 mtruj013 deleted the security-esm branch February 28, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants