Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net install is not silent #614

Closed
TheCakeIsNaOH opened this issue Jan 8, 2021 · 6 comments
Closed

.Net install is not silent #614

TheCakeIsNaOH opened this issue Jan 8, 2021 · 6 comments

Comments

@TheCakeIsNaOH
Copy link
Contributor

So the version 1.1.27 chocolatey package is failing verification testing (log) because the dotnet installer hangs waiting for the finish button to be clicked, which means that the synctrazyor installer never completes and thus times out the test.

There are two major options that I see:

  1. Fix the dotnet installer so it does not show the installation is complete screen.
  2. Take a chocolatey dependency on dotnet via the dotnetfx package, so the synctrayzor installer does not need to install dotnet.

Option one is not ideal, as changing the arguments for the dotnet installer inside the synctrazyor installer might make for a worse experience for normal users, because a completely quiet install does not show the close apps warning for example. Additionally, the Chocolatey mods probably prefer that the dotnet be a dependency.

Option two does not work %100 currently. The problem is that if you install dotnet, the registry key with the current installed version does not get updated until after a reboot. So even if a dependency is taken on dotnetfx, synctrazyor will still re-install it, and then hang on the finish screen. This could be fixed at least two ways. The first would be to add an argument the synctrazyor installer to completely skip the .Net install. The second would be to find a way to detect if a high enough dotnet version is installed, even if the registry has not been updated.

@canton7
Copy link
Owner

canton7 commented Jan 8, 2021 via email

@canton7
Copy link
Owner

canton7 commented Jan 8, 2021

I'd probably prefer putting the dependency in the nuspec, and passing a flag to the synctrayzor installer telling it not to try to install net. Thoughts?

@TheCakeIsNaOH
Copy link
Contributor Author

Sorry, its been a busy week: this is on my backlog.

No problem, sorry again about not putting enough testing into my previous PRs.

I'd probably prefer putting the dependency in the nuspec, and passing a flag to the synctrayzor installer telling it not to try to install net. Thoughts?

That's my preferred option as well,

@canton7
Copy link
Owner

canton7 commented Jan 8, 2021

That's OK! You saw how many people I broke with the last few releases...

TheCakeIsNaOH added a commit to TheCakeIsNaOH/SyncTrayzor that referenced this issue Jan 8, 2021
TheCakeIsNaOH added a commit to TheCakeIsNaOH/SyncTrayzor that referenced this issue Jan 8, 2021
canton7 added a commit to TheCakeIsNaOH/SyncTrayzor that referenced this issue Jan 10, 2021
@canton7
Copy link
Owner

canton7 commented Mar 6, 2021

Version 1.1.28, which should fix this. Let's see how the moderation process goes....

@canton7 canton7 closed this as completed Mar 6, 2021
@Ivoz
Copy link

Ivoz commented Mar 7, 2021

Synctrayzor updated seamlessly for me on 1.1.28 with choco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants