-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pako dependency to version ^2.0.2 for better tree shaking #24
Comments
Hey there! We can do that, but pdf-lib relies on:
Both of them rely on pako 1... |
Right... and both Hopding/standard-fonts#2 and Hopding/upng#1 are dead in the water... How about forking the dependencies as well? |
Ok, let's do that:
|
I'm currently working for a client that uses this package, so I would have to ask them about spending my time on the upng-package. As for the standard-fonts package, I would not be able to maintain this over time, so it seems like a bad idea for me to fork it. Maybe someone who's more invested in the package could do it? |
Would your client be able to maintain it? |
I really doubt that's going to happen |
I just published a standard-fonts package with updated dependency, mind trying it out |
@andreaslarssen @DineshSolanki Can someone open a PR on UPNG.js to upgrade pako, or at least open an issue explaining the problem? This way we don't need to open and maintain yet another fork. |
Will this PR solve it? |
I don't know. We need pako 2 I believe, no? |
Describe your idea
From Hopding#689:
How could this be implemented?
See above
What problem are you trying to solve?
See above
Why does this matter to you?
Optimization bailouts, and prevents us from upgrading to Angular 16 (?)
Would others find this helpful?
Yes
Are you interested in implementing your proposal?
No
Why are you submitting a proposal?
To keep the lib alive
Additional Notes
No response
The text was updated successfully, but these errors were encountered: