Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pako dependency to version ^2.0.2 for better tree shaking #689

Closed
lpl14 opened this issue Dec 3, 2020 · 12 comments
Closed

Update pako dependency to version ^2.0.2 for better tree shaking #689

lpl14 opened this issue Dec 3, 2020 · 12 comments

Comments

@lpl14
Copy link

lpl14 commented Dec 3, 2020

Angular11 generates warnings for pdf-lib because of the old module format of pako

Warning: C:\Users\*****\node_modules\pdf-lib\es\core\PDFContext.js depends on 'pako'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: C:\Users\*****\node_modules@pdf-lib\upng\UPNG.js depends on 'pako'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Recently pako switched with version 2.0.0 to es6. Would it be possible to update the dependency?
Thank you!

@lpl14 lpl14 changed the title Update pako dependency to version ^2.0.2 Update pako dependency to version ^2.0.2 for better tree shaking Dec 9, 2020
@Hopding
Copy link
Owner

Hopding commented Jan 2, 2021

Hello @lpl14! It should be possible to upgrade pdf-lib to the latest version of pako. I don't have time to work on this right now, but I'd be happy to accept a PR for it!

@jwfx
Copy link

jwfx commented Apr 27, 2022

@Hopding
Since both pull requests didn't go through, this issue should probably be reopened again as this issue still persists?

@DineshSolanki
Copy link

is there any update on this

@andreaslarssen
Copy link

Is there anyone here with permission to reopen please?

@jwfx
Copy link

jwfx commented May 23, 2023

@andreaslarssen

I think by now this project here can safely be pronounced dead, see also: #1423 (comment)

@andreaslarssen
Copy link

@andreaslarssen

I think by now this project here can safely be pronounced dead, see also: #1423 (comment)

Thanks, added issue to forked repo and hoping for the best:
cantoo-scribe#24

@Sharcoux
Copy link

Hi guys,

The following dependencies of pdf-lib rely on pako 1.

  • "@pdf-lib/standard-fonts": "^1.0.0",
  • "@pdf-lib/upng": "^1.0.1",

I'm not sure what we can do without Hopding, unless we fork all 3 projects, but I'm not so sure that we can maintain all that...

@Sharcoux
Copy link

@DineshSolanki @jwfx Would anyone of you be able to maintain a fork of @pdf-lib/standard-fonts ?

@DineshSolanki
Copy link

Yes, I think I can take it up. Just let me know if there's something specific that would need to be taken care also

@andreaslarssen
Copy link

@DineshSolanki
Copy link

@DineshSolanki : see cantoo-scribe#24 (comment)

Okay, I'll take a look, I'm not really the js guy, but will check, if I understand it properly then might some time into it

@DineshSolanki
Copy link

@DineshSolanki : see cantoo-scribe#24 (comment)

I just published a standard-fonts package with updated dependency, mind trying it out
https://www.npmjs.com/package/@dineshsolanki/standard-fonts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants