fix: do not create case when stmts for comparison operators #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobdenOs
approved these changes
Nov 13, 2023
danjoa
reviewed
Dec 12, 2023
danjoa
reviewed
Jan 29, 2024
Comment on lines
+649
to
+659
| '==': true, | ||
| '!=': false, | ||
| // REVISIT: not required for now. application must do case when statement themselves | ||
| // These operators are not allowed in column expressions | ||
| '>': null, | ||
| '<': null, | ||
| '<>': null, | ||
| '>=': null, | ||
| '<=': null, | ||
| '!<': null, | ||
| '!>': null, | ||
| // '>': null, | ||
| // '<': null, | ||
| // '<>': null, | ||
| // '>=': null, | ||
| // '<=': null, | ||
| // '!<': null, | ||
| // '!>': null, |
There was a problem hiding this comment.
Would that change specified behavior?
There was a problem hiding this comment.
This change only impacts the usage of these operators where HANA does not allow for them.
SELECT 1>0 as gt FROM DUMMYCurrently considering to close this PR as #426 does the same with more fixes.
|
obsolete due to #426 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.