ENH/DEP: add temporary action pending framework fix #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thermokarst
reviewed
Jul 29, 2020
| output_descriptions={ | ||
| 'labeled_seqs': 'The re-labeled sequences.' | ||
| }, | ||
| name='Re-label unaligned sequences (deprecated)', |
There was a problem hiding this comment.
Maybe you should include a deprecated=True argument in this method registration, too, that way interfaces will indicate the deprecated status.
There was a problem hiding this comment.
I can put a PR in for that, too - just let me know.
|
Sorry, I'm sure y'all have discussed at length, and I'm just butting in, but what is the issue here? Can't the framework handle this case just fine right now, since both of these types are working with the same view type? |
Following up to my own question: in theory, yes, but in practice, no: qiime2/qiime2#547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.