Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash: fix path containing space with ~ prefix #1114

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

rsteube
Copy link
Member

@rsteube rsteube commented Feb 20, 2025

fix #1113

@coveralls
Copy link

coveralls commented Feb 20, 2025

Pull Request Test Coverage Report for Build 13443915653

Details

  • 1 of 7 (14.29%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 57.638%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/shell/bash/action.go 0 6 0.0%
Totals Coverage Status
Change from base Build 13377506621: 0.07%
Covered Lines: 3128
Relevant Lines: 5427

💛 - Coveralls

@rsteube rsteube marked this pull request as draft February 20, 2025 19:38
Path was only partially quoted for homedir expansion to work.
But seems bash doesn't like this so we need to use escaping.
@rsteube rsteube force-pushed the bash-fix-homedir-space branch from 72620d2 to d0a0896 Compare February 20, 2025 20:17
@rsteube rsteube marked this pull request as ready for review February 20, 2025 20:21
@rsteube rsteube merged commit b0919a0 into master Feb 20, 2025
35 checks passed
@rsteube rsteube deleted the bash-fix-homedir-space branch February 20, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ls: completion fails for ~/blah/blah/ when containing items with spaces
2 participants