Remove ruby e2e tests #5009
Open
Remove ruby e2e tests #5009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
force-pushed
the
anviking/4980/delete-ruby-e2e
branch
2 times, most recently
from
4850e7d to
97e5e8f
Compare
Anviking
force-pushed
the
anviking/4980/delete-ruby-e2e
branch
8 times, most recently
from
916add5 to
2f9cf81
Compare
Anviking
commented
Feb 28, 2025
.buildkite/pipeline.yml
Outdated
| - buildkite-agent artifact download "windows-tests.zip" . | ||
| - mkdir -p windows\tests | ||
| - tar -xf windows-tests.zip -C windows\tests | ||
| - cd windows\tests # tests seem to look for test data relative to ..\.. |
There was a problem hiding this comment.
Suggested change
| - cd windows\tests # tests seem to look for test data relative to ..\.. | |
| - cd windows\tests # tests seem to rely on ..\.. being the repo root |
There was a problem hiding this comment.
Also it would have made sense to factor out the "download artifact >> mkdir >> tar xf >> cd" to some common download-windows-tests.sh — but with this difference in path I'm not sure it's worth it.
Could have windows\tests be the directory in all the cases I suppose.
I think it's fine to keep duplicated though.
|
Appears to be about to pass: https://buildkite.com/cardano-foundation/cardano-wallet/builds/9541#_ |
Anviking
commented
Feb 28, 2025
| @@ -580,7 +583,10 @@ steps: | |||
| - trigger-windows-e2e-tests | |||
| commands: | |||
| - diff -r configs/cardano/preprod lib/integration/configs/cardano/preprod # ensure the configs don't diverge despite being duplicated | |||
| - ./scripts/buildkite/main/windows-e2e.bat | |||
There was a problem hiding this comment.
Turns out we don't need the .bat file any longer
Anviking
force-pushed
the
anviking/4980/delete-ruby-e2e
branch
from
2f9cf81 to
ba3fb27
Compare
Anviking
force-pushed
the
anviking/4980/delete-ruby-e2e
branch
from
649e4ac to
e409fa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments
Per #4980 (comment) this should be fine.
Issue Number
#4980