Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump x/tools to 0.30.0 to support Go 1.24 #51

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

alexandear
Copy link
Contributor

This PR fixes perfsprint to work with Go 1.24.

How to reproduce

Build perfsprint with Go 1.24, run and get "internal error".

$ go version
go version go1.24.0 darwin/arm64

$ go build -o perfsprint main.go

Expected

$ ./perfsprint ./...
/Users/Oleksandr_Redko/src/github.com/catenacyber/perfsprint/analyzer/analyzer_test.go:60:12: fmt.Sprintf can be replaced with just using the string
/Users/Oleksandr_Redko/src/github.com/catenacyber/perfsprint/analyzer/analyzer_test.go:61:12: fmt.Sprintf can be replaced with just using the string
/Users/Oleksandr_Redko/src/github.com/catenacyber/perfsprint/analyzer/analyzer_test.go:62:12: fmt.Sprint can be replaced with just using the string
...

Actual

$ ./perfsprint ./...
perfsprint: internal error: package "bytes" without types was imported from "github.com/catenacyber/perfsprint/analyzer"

Copy link
Owner

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@catenacyber catenacyber merged commit 5b89c6e into catenacyber:main Feb 18, 2025
3 checks passed
@alexandear alexandear deleted the fix/go-1-24 branch February 18, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants