Multiple ids #39
Merged
Multiple ids #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
covers 4 of the other 5: magnet URI, SSB, subresource, and named-info. Haven't figured out base58 encoding for multihashes...
This adds support to recognize different identifier formats in functions that take a content identifier as an argument (`retrieve`, `resolve`, `query_sources`). This also adds potential columns in the local tsv registry to compute multiple hashes, but at this time we have not implemented multiple hash calculations. Performance issues should be mitigated by streaming, #38
still needs cleaning up and more testing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds preliminary support for multiple identifier formats (#1) in functions taking an identifier as an argument.
hash://sha256/xxformat remains the internal format, this is just using regex's and base64 decoding to recognize and convert other identifier formats (SSB, SRI, magnet, and NI).This also starts setting up support for storing multiple hash types in the local tsv registry, but currently these are just placeholders until we can efficiently compute other hashes (#38). Even then,
store()will remainsha256-based, these additional hashes will really just be for the local registry. (these multiple hash types are already understood by hash-archive.org: md5, sha1, sha256, sha384, sha512).