Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbound energy #81

Merged
merged 4 commits into from
Mar 5, 2022
Merged

Unbound energy #81

merged 4 commits into from
Mar 5, 2022

Conversation

klgunst
Copy link
Contributor

@klgunst klgunst commented Jan 27, 2022

  • When using VINA or VINARDO as scoring and using refinement of the structures after docking, the Unbound System's energy was obtained from the worst pose instead of the best pose.
    I couldn't reproduce it locally, but I expect it to close issue python script results in unexpected very negative affinity score #68.
  • Fix typo as pointed out in issue python script results in unexpected very negative affinity score #68 and fixed sign-inconsistency for unbound system's energy between different scorings.
  • Expose score(unbound_energy) in python bindings and CLI (through --unbound_energy when using --score_only). This is handy when you want to rescore a pose with a 'custom' unbound energy (i.e. if you are not using the intramolecular energy of that particular pose as unbound energy).

@diogomart
Copy link
Member

Thank you @klgunst for this PR. I can confirm that the large energies reported in #68 no longer occur. I'll run a few more checks and will probably merge soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants