-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global phase #166
Global phase #166
Conversation
Codecov Report
@@ Coverage Diff @@
## main #166 +/- ##
=====================================
Coverage 84.1% 84.2%
=====================================
Files 48 48
Lines 8238 8255 +17
=====================================
+ Hits 6935 6952 +17
Misses 1303 1303
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for this PR!
Just a couple of small things/questions:
- why were the
json
andpybind11
submodules touched in this PR? - just to double check: the
rx
gate does not need a global phase? - for the rest of the questions, see below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
Added global phases to certain gates (like RZ) during parsing.