Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global phase #166

Merged
merged 9 commits into from
Aug 12, 2022
Merged

Global phase #166

merged 9 commits into from
Aug 12, 2022

Conversation

pehamTom
Copy link
Member

Added global phases to certain gates (like RZ) during parsing.

@pehamTom pehamTom requested a review from burgholzer August 12, 2022 14:40
@pehamTom pehamTom added the enhancement New feature or request label Aug 12, 2022
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #166 (0d5b942) into main (8f1d73b) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #166   +/-   ##
=====================================
  Coverage   84.1%   84.2%           
=====================================
  Files         48      48           
  Lines       8238    8255   +17     
=====================================
+ Hits        6935    6952   +17     
  Misses      1303    1303           
Impacted Files Coverage Δ
src/zx/FunctionalityConstruction.cpp 96.3% <100.0%> (+0.1%) ⬆️
test/unittests/test_zx_functionality.cpp 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this PR!

Just a couple of small things/questions:

  • why were the json and pybind11 submodules touched in this PR?
  • just to double check: the rx gate does not need a global phase?
  • for the rest of the questions, see below.

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@burgholzer burgholzer merged commit 60a9f60 into main Aug 12, 2022
@burgholzer burgholzer deleted the global-phase branch December 2, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants