-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbolic #199
Conversation
Co-authored-by: Lukas Burgholzer <[email protected]>
Co-authored-by: Lukas Burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
…ever suitable) Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Added predicate that allows to check whether a QuantumComputation can be transformed to a ZX-diagram.
Codecov Report
@@ Coverage Diff @@
## main #199 +/- ##
=======================================
+ Coverage 84.1% 84.5% +0.4%
=======================================
Files 48 51 +3
Lines 8268 8693 +425
=======================================
+ Hits 6955 7352 +397
- Misses 1313 1341 +28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for this contribution. I just went through all the code and you can find my comments inline. Most of them should be fairly easy to address (const
😈 ). Maybe a handful probably require a small to medium effort.
I guess this should be ready to merge after that iteration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ready to merge after all conversations have been resolved
This PR introduced functionality for equivalence checking of parametrized circuits with QCEC. This PR is related to cda-tum/mqt-core#199 and cda-tum/zx#15 Signed-off-by: Lukas Burgholzer <[email protected]> Co-authored-by: Lukas Burgholzer <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Lukas Burgholzer <[email protected]>
This PR adds a representation for Quantum Circuits that have symbolic parameters. The symbolic computations are handled within the MQT ZX Package.