Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolic #199

Merged
merged 82 commits into from
Oct 21, 2022
Merged

Symbolic #199

merged 82 commits into from
Oct 21, 2022

Conversation

pehamTom
Copy link
Member

@pehamTom pehamTom commented Oct 5, 2022

This PR adds a representation for Quantum Circuits that have symbolic parameters. The symbolic computations are handled within the MQT ZX Package.

pehamTom and others added 30 commits June 20, 2022 10:19
Co-authored-by: Lukas Burgholzer <[email protected]>
Co-authored-by: Lukas Burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Added predicate that allows to check whether a QuantumComputation can be transformed to a ZX-diagram.
@pehamTom pehamTom mentioned this pull request Oct 5, 2022
4 tasks
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #199 (553e895) into main (6b897ff) will increase coverage by 0.4%.
The diff coverage is 93.9%.

@@           Coverage Diff           @@
##            main    #199     +/-   ##
=======================================
+ Coverage   84.1%   84.5%   +0.4%     
=======================================
  Files         48      51      +3     
  Lines       8268    8693    +425     
=======================================
+ Hits        6955    7352    +397     
- Misses      1313    1341     +28     
Impacted Files Coverage Δ
include/Definitions.hpp 69.2% <ø> (-5.8%) ⬇️
include/operations/CompoundOperation.hpp 81.1% <0.0%> (-2.5%) ⬇️
include/operations/StandardOperation.hpp 100.0% <ø> (ø)
src/operations/SymbolicOperation.cpp 86.5% <86.5%> (ø)
include/operations/SymbolicOperation.hpp 91.6% <91.6%> (ø)
src/zx/FunctionalityConstruction.cpp 96.2% <95.6%> (-0.2%) ⬇️
include/QuantumComputation.hpp 94.1% <100.0%> (+0.1%) ⬆️
include/operations/Operation.hpp 93.9% <100.0%> (+0.3%) ⬆️
src/QuantumComputation.cpp 69.3% <100.0%> (+3.9%) ⬆️
src/operations/Operation.cpp 86.9% <100.0%> (+0.3%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this contribution. I just went through all the code and you can find my comments inline. Most of them should be fairly easy to address (const 😈 ). Maybe a handful probably require a small to medium effort.
I guess this should be ready to merge after that iteration.

@burgholzer burgholzer added the enhancement New feature or request label Oct 18, 2022
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ready to merge after all conversations have been resolved

@pehamTom pehamTom merged commit b140c2e into main Oct 21, 2022
burgholzer added a commit to cda-tum/mqt-qcec that referenced this pull request Oct 21, 2022
This PR introduced functionality for equivalence checking of
parametrized circuits with QCEC. This PR is related to
cda-tum/mqt-core#199 and
cda-tum/zx#15

Signed-off-by: Lukas Burgholzer <[email protected]>
Co-authored-by: Lukas Burgholzer <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Lukas Burgholzer <[email protected]>
@burgholzer burgholzer deleted the symbolic branch December 2, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants