Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a wrong property in CMake #257

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Fixed a wrong property in CMake #257

merged 1 commit into from
Jan 26, 2023

Conversation

hillmich
Copy link
Collaborator

- Make nlohmann_json a system include to suppress potential warnings
@hillmich hillmich added the bug Something isn't working label Jan 26, 2023
@hillmich hillmich requested a review from burgholzer January 26, 2023 12:28
@hillmich hillmich self-assigned this Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #257 (b7ee319) into main (a7d0ab9) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #257   +/-   ##
=====================================
  Coverage   84.0%   84.0%           
=====================================
  Files         58      58           
  Lines       6974    6974           
  Branches    1387    1387           
=====================================
  Hits        5860    5860           
  Misses      1114    1114           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that mistake 👍🏼

@burgholzer burgholzer merged commit b00c4cc into main Jan 26, 2023
@burgholzer burgholzer deleted the fix-system-includes branch January 26, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants