Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update DD package submodule #283

Merged
merged 4 commits into from
Mar 16, 2023
Merged

⬆️ Update DD package submodule #283

merged 4 commits into from
Mar 16, 2023

Conversation

aaronleesander
Copy link
Collaborator

@aaronleesander aaronleesander commented Mar 16, 2023

This PR just updates the DD package submodule with a fix in the expectationValue function of the DD package.

@aaronleesander aaronleesander added the dependencies Pull requests that update a dependency file label Mar 16, 2023
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the DD package should be updated here. Everything else should stay the same.

@aaronleesander aaronleesander changed the title update DD package and zx submodules update DD package submodule Mar 16, 2023
@burgholzer
Copy link
Member

That might be the wrong DD package branch. You probably want to switch to the main branch locally, update that by pulling the latest changes and then committing the result.

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we are talking ✅

@burgholzer burgholzer changed the title update DD package submodule ⬆️ Update DD package submodule Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #283 (905926e) into main (eda5be1) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #283   +/-   ##
=====================================
  Coverage   87.1%   87.1%           
=====================================
  Files         58      58           
  Lines       6718    6718           
  Branches    1349    1349           
=====================================
  Hits        5855    5855           
  Misses       863     863           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@burgholzer burgholzer enabled auto-merge (squash) March 16, 2023 16:43
@burgholzer burgholzer merged commit 94229bf into main Mar 16, 2023
@burgholzer burgholzer deleted the update-DD-package branch March 16, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants