Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opaque teleportation gate #286

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Add opaque teleportation gate #286

merged 4 commits into from
Mar 22, 2023

Conversation

hillmich
Copy link
Collaborator

If teleportation was used in mapping, add an opaque gate to the output.

@hillmich hillmich added the enhancement New feature or request label Mar 22, 2023
@hillmich hillmich requested a review from burgholzer March 22, 2023 12:43
@hillmich hillmich self-assigned this Mar 22, 2023
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one issue that's stopping the code from compiling, this lgtm.
Adding a simple test that confirms that dumping works, would be great.
In the best case, there is also a test that makes sure the resulting circuit can be read in again and yields the same QuantumComputation used for dumping.

@hillmich hillmich force-pushed the opaque-teleportation branch from fddfd05 to 6dab496 Compare March 22, 2023 12:53
- If teleportation was used in mapping, add an opaque gate to the output
@hillmich hillmich force-pushed the opaque-teleportation branch from f65bb90 to 9b83b19 Compare March 22, 2023 12:53
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #286 (ca12a1a) into main (9dbdebc) will increase coverage by 0.2%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #286     +/-   ##
=======================================
+ Coverage   87.1%   87.4%   +0.2%     
=======================================
  Files         58      58             
  Lines       6728    6729      +1     
  Branches    1352    1351      -1     
=======================================
+ Hits        5865    5886     +21     
+ Misses       863     843     -20     
Impacted Files Coverage Δ
include/parsers/qasm_parser/Parser.hpp 100.0% <ø> (ø)
src/QuantumComputation.cpp 77.5% <100.0%> (+<0.1%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hillmich
Copy link
Collaborator Author

I fixed the error and added a test 👍

@hillmich hillmich requested a review from burgholzer March 22, 2023 13:19
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Many thanks 🙏

@hillmich hillmich enabled auto-merge (squash) March 22, 2023 13:34
@hillmich hillmich merged commit 86a8676 into main Mar 22, 2023
@hillmich hillmich deleted the opaque-teleportation branch March 22, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants