-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opaque teleportation gate #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the one issue that's stopping the code from compiling, this lgtm.
Adding a simple test that confirms that dumping works, would be great.
In the best case, there is also a test that makes sure the resulting circuit can be read in again and yields the same QuantumComputation used for dumping.
fddfd05
to
6dab496
Compare
- If teleportation was used in mapping, add an opaque gate to the output
f65bb90
to
9b83b19
Compare
Codecov Report
@@ Coverage Diff @@
## main #286 +/- ##
=======================================
+ Coverage 87.1% 87.4% +0.2%
=======================================
Files 58 58
Lines 6728 6729 +1
Branches 1352 1351 -1
=======================================
+ Hits 5865 5886 +21
+ Misses 863 843 -20
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I fixed the error and added a test 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Many thanks 🙏
If teleportation was used in mapping, add an opaque gate to the output.